-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully abstracted file system, plus code quality improvements. #34
Fully abstracted file system, plus code quality improvements. #34
Conversation
I really appreciate this commit! Looks like a lot of hard work went into it. There's two things that keep me from merging it right away:
|
Hey Lars, I wanted to say thank you for all the work you've put into this project (especially recently, I have a basic implementation of the latest changes working in Friday Night Funkin' already). It's very powerful and flexible as is, and every bit of effort you put into making it better is much appreciated. In terms of the code formatting changes, I put them in their own commit, but I realize now that the "Files changed" view doesn't let you filter by that. I'll move them to their own PR. (EDIT: That's apparently easier said than done, Git HATES working with two branches with different formatting.) As for the Electron PR, I can test merging the branches together and see how that plays out. |
Thanks for working with me here :) I also just realized that some of my samples are out of date, such as the Heaps demo. Lot of maintenance work to catch up on, and I don't even have any unit tests, I just rely on the samples telling me if something seems broken or not. |
Hey, I've force pushed a new commit which removes the formatting changes. As for the Electron support, it appears that the two changes are absolutely not compatible due to major merge conflicts. @TamarCurry adds a new NodeFileSystem but doesn't implement the interface I created here. For this to work, we need to have one developer's changes be merged and have the other rework their PR to be compatible. |
Yeah, I figured as much. So I promised Tamar that I would look into his first as he's been waiting patiently for over a week now. I may need to get directly involved to deal with the cleanup work to reconcile his with yours, if you're okay with that. |
That's fine with me, as long as it doesn't put too much work on your plate. 😄 |
Eh, all in the day of a life of an open source maintainer. If you'll be patient with me we'll get this sorted eventually. |
This PR performs the following changes:
PolymodFileSystem
with access to an instance of IFileSystem. This defaults to SysFileSystem if available.