Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change callback #87

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Change callback #87

merged 1 commit into from
Apr 26, 2016

Conversation

mchapman
Copy link
Contributor

While trying to figure out an issue in my app I introduced a failing test, and got

SUMMARY:
✔ 26 tests completed
✖ 1 test failed

FAILED TESTS:
  ClickerApp
    ✖ initialises with two possible pages
      PhantomJS 2.1.1 (Linux 0.0.0)
    Expected 2 to equal 6.
    /home/mark/Projects/clicker/www/build/test/test.bundle.js:9:9984

[17:05:34] 'karma' errored after 7.4 s
[17:05:34] Error: 1
    at formatError (/home/mark/Projects/clicker/node_modules/gulp/bin/gulp.js:169:10)
    at Gulp.<anonymous> (/home/mark/Projects/clicker/node_modules/gulp/bin/gulp.js:195:15)
    at emitOne (events.js:82:20)
    at Gulp.emit (events.js:169:7)
    at Gulp.Orchestrator._emitTaskDone (/home/mark/Projects/clicker/node_modules/gulp/node_modules/orchestrator/index.js:264:8)
    at /home/mark/Projects/clicker/node_modules/gulp/node_modules/orchestrator/index.js:275:23
    at finish (/home/mark/Projects/clicker/node_modules/gulp/node_modules/orchestrator/lib/runTask.js:21:8)
    at cb (/home/mark/Projects/clicker/node_modules/gulp/node_modules/orchestrator/lib/runTask.js:29:3)
    at removeAllListeners (/home/mark/Projects/clicker/node_modules/karma/lib/server.js:336:7)
    at Server.<anonymous> (/home/mark/Projects/clicker/node_modules/karma/lib/server.js:347:9)
    at Server.g (events.js:260:16)
    at emitNone (events.js:72:20)
    at Server.emit (events.js:166:7)
    at emitCloseNT (net.js:1521:8)
    at nextTickCallbackWith1Arg (node.js:431:9)
    at process._tickCallback (node.js:353:17)
[17:05:34] 'unit-test' errored after 19 s
[17:05:34] Error in plugin 'run-sequence'
Message:
    An error occured in task 'karma'.
npm ERR! Test failed.  See above for more details.

I found https://stackoverflow.com/questions/26614738/issue-running-karma-task-from-gulp and made this small change, which seems to improve things.

@lathonez
Copy link
Owner

Thank you! I've noticed this a couple of times but have never got myself into a state where I could reliably reproduce it.

@lathonez lathonez merged commit f3b6641 into lathonez:master Apr 26, 2016
@mchapman mchapman deleted the patch-2 branch April 26, 2016 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants