-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup/gf format fixes #1204
base: develop
Are you sure you want to change the base?
Cleanup/gf format fixes #1204
Conversation
…fixing that allows for fine grained control and gauge IO
… fixing that allows for fine grained control and gauge IO.
…e/quda into cleanup/gf_test_interface
…auge fixing stdout and comments
…fixing that allows for fine grained control and gauge IO
… fixing that allows for fine grained control and gauge IO.
…auge fixing stdout and comments
…priate. Fix gauge dir error in gauge_alg_test, adjust step output in gauge fixing
…GaugeFixParam to define both parameters and algorithm, format variable names to be consistent, use QudaBoolean for booleans rather than integers
Thanks @cpviolator. This looks like a great cleanup of the gauge fixing interface. A few outstanding issues:
|
The gauge fixing interface does two things:
In both cases, the fixed gauge field observables are compared to the unfixed values. |
…d other tests to use a CL supplied seed)
I've addressed online and offline comments and suggestions. Both the GPU kernel and interface functions now use a new parameter struct that wholly defines the gauge fixing. The Google Test Suite tests the GPU kernel function calls directly, and the individual test uses the I also introduced a new CL parameter |
@maddyscientist Actually, hold off for a bit. Some precisions are not being set correctly. |
…precision, fix bug where gauge field boundary is not set to periodic
Some test commands: To test an individual test type (FFT, Landau) in single prec, save the gauge, then load the fixed gauge and compute in double.
To perform the Google test.
@maddyscientist The above are working well, which shows that the Google test for GPU functions, spot test for |
This PR adds CL params for the gauge fixing routines so that one can control the parameters. The original gauge alg test is now a ctest with the Google testing suite, and the file gauge_alg_test.cpp performs only a single gauge fix test specified by the user, with the option to save the gauge field.
It also consolidates the gauge fixing routines using a QudaGaugeFixParam struct to define the workflow.
This PR escapes the formatting issues in https://github.com/lattice/quda/tree/cleanup/gf_test_interface and supersedes it.