Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run test published package action with Windows OS #2345

Merged
merged 9 commits into from
Feb 29, 2024
Merged

feat: run test published package action with Windows OS #2345

merged 9 commits into from
Feb 29, 2024

Conversation

yonadaaa
Copy link
Contributor

@yonadaaa yonadaaa commented Feb 28, 2024 •
edited by holic
Loading

sort of helps with #2197

I ran it on pull_request trigger and it worked:
https://github.com/latticexyz/mud/actions/runs/8086204287?pr=2345

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0020671

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yonadaaa yonadaaa changed the title feat: create mud action feat: add OS matrix to test published package action Feb 28, 2024
@yonadaaa yonadaaa changed the title feat: add OS matrix to test published package action feat: run test published package action with multiple OS's Feb 28, 2024
@yonadaaa yonadaaa changed the title feat: run test published package action with multiple OS's feat: run test published package action with Windows OS's Feb 28, 2024
@yonadaaa yonadaaa changed the title feat: run test published package action with Windows OS's feat: run test published package action with Windows OS Feb 28, 2024
@yonadaaa yonadaaa marked this pull request as ready for review February 28, 2024 19:53
@holic holic merged commit bf79ed5 into main Feb 29, 2024
12 checks passed
@holic holic deleted the yonadaaa/create-mud-action branch February 29, 2024 11:22
@holic
Copy link
Member

holic commented Feb 29, 2024

going to keep #2197 open for now so we can add windows to our regular CI runner (not just published packages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonadaaa @holic