Change s3_staging_dir argument to optional (fix #99) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 91.97% 91.99% +0.02%
==========================================
Files 14 14
Lines 1009 1062 +53
==========================================
+ Hits 928 977 +49
- Misses 81 85 +4
Continue to review full report at Codecov.
|
laughingman7743
force-pushed
the
change_s3_staging_dir_argument_to_optional
branch
from
d7d0f0e
to
3c1798d
Compare
laughingman7743
force-pushed
the
change_s3_staging_dir_argument_to_optional
branch
3 times, most recently
from
68b8f64
to
917dc6d
Compare
laughingman7743
force-pushed
the
change_s3_staging_dir_argument_to_optional
branch
2 times, most recently
from
2b09649
to
697ebac
Compare
laughingman7743
force-pushed
the
change_s3_staging_dir_argument_to_optional
branch
from
697ebac
to
9166710
Compare
laughingman7743
deleted the
change_s3_staging_dir_argument_to_optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.