Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel the query when KeybordInterrupt occurs (fix #28) #31

Closed
wants to merge 1 commit into from

Conversation

laughingman7743
Copy link
Owner

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 31, 2018

Codecov Report

Merging #31 into master will increase coverage by 0.07%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   92.16%   92.24%   +0.07%     
==========================================
  Files          13       12       -1     
  Lines         945      774     -171     
==========================================
- Hits          871      714     -157     
+ Misses         74       60      -14
Impacted Files Coverage Δ
pyathena/common.py 86.84% <55.55%> (-1.95%) ⬇️
pyathena/__init__.py 82.14% <0%> (-2.71%) ⬇️
pyathena/result_set.py 90.84% <0%> (-2.7%) ⬇️
pyathena/util.py 86.36% <0%> (-2.1%) ⬇️
pyathena/converter.py 80.76% <0%> (-0.49%) ⬇️
pyathena/async_cursor.py 93.47% <0%> (ø) ⬆️
pyathena/cursor.py 100% <0%> (ø) ⬆️
pyathena/formatter.py 96.96% <0%> (ø) ⬆️
pyathena/model.py 92.15% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45599c5...1dcb9a2. Read the comment docs.

@Spacerat
Copy link

Spacerat commented May 9, 2018

I just tested this in a notebook and it seems to work. Is the codecov regression preventing this from being merged, or something else?

@laughingman7743
Copy link
Owner Author

#28 (comment)

I don't think this is enough since the interruption could be catched at another part. A finally clause checking for the query execution state would be a more robust alternative, although that can't be done at the _poll level.

@Spacerat
I think that test coverage is no problem. If this implementation looks good, I will merge this branch.

@laughingman7743
Copy link
Owner Author

#150

@laughingman7743 laughingman7743 deleted the catch_keyboardinterrupt branch September 11, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants