Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bundling tests when packaging #86

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

gaqzi
Copy link
Contributor

@gaqzi gaqzi commented Jun 18, 2019

Before this the tests would be installed alongside the package, meaning that
there'd be a global tests package installed alongside pyathena.

As a user of pyathena I don't need the tests in production and would rather
not have them installed. :)

I tested this locally and running without this change I saw:

$ python setup.py sdist
running sdist
running egg_info
writing PyAthena.egg-info/PKG-INFO
writing dependency_links to PyAthena.egg-info/dependency_links.txt
writing entry points to PyAthena.egg-info/entry_points.txt
writing requirements to PyAthena.egg-info/requires.txt
writing top-level names to PyAthena.egg-info/top_level.txt
reading manifest file 'PyAthena.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'PyAthena.egg-info/SOURCES.txt'
running check
creating PyAthena-1.7.0
creating PyAthena-1.7.0/PyAthena.egg-info
creating PyAthena-1.7.0/pyathena
creating PyAthena-1.7.0/tests
copying files to PyAthena-1.7.0...
copying LICENSE -> PyAthena-1.7.0
copying MANIFEST.in -> PyAthena-1.7.0
copying Pipfile -> PyAthena-1.7.0
copying Pipfile.lock -> PyAthena-1.7.0
copying README.rst -> PyAthena-1.7.0
copying setup.cfg -> PyAthena-1.7.0
copying setup.py -> PyAthena-1.7.0
copying PyAthena.egg-info/PKG-INFO -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/SOURCES.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/dependency_links.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/entry_points.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/not-zip-safe -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/requires.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/top_level.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying pyathena/__init__.py -> PyAthena-1.7.0/pyathena
copying pyathena/async_cursor.py -> PyAthena-1.7.0/pyathena
copying pyathena/async_pandas_cursor.py -> PyAthena-1.7.0/pyathena
copying pyathena/common.py -> PyAthena-1.7.0/pyathena
copying pyathena/connection.py -> PyAthena-1.7.0/pyathena
copying pyathena/converter.py -> PyAthena-1.7.0/pyathena
copying pyathena/cursor.py -> PyAthena-1.7.0/pyathena
copying pyathena/error.py -> PyAthena-1.7.0/pyathena
copying pyathena/formatter.py -> PyAthena-1.7.0/pyathena
copying pyathena/model.py -> PyAthena-1.7.0/pyathena
copying pyathena/pandas_cursor.py -> PyAthena-1.7.0/pyathena
copying pyathena/result_set.py -> PyAthena-1.7.0/pyathena
copying pyathena/sqlalchemy_athena.py -> PyAthena-1.7.0/pyathena
copying pyathena/util.py -> PyAthena-1.7.0/pyathena
copying tests/__init__.py -> PyAthena-1.7.0/tests
copying tests/conftest.py -> PyAthena-1.7.0/tests
copying tests/test_async_cursor.py -> PyAthena-1.7.0/tests
copying tests/test_async_pandas_cursor.py -> PyAthena-1.7.0/tests
copying tests/test_cursor.py -> PyAthena-1.7.0/tests
copying tests/test_formatter.py -> PyAthena-1.7.0/tests
copying tests/test_pandas_cursor.py -> PyAthena-1.7.0/tests
copying tests/test_result_set.py -> PyAthena-1.7.0/tests
copying tests/test_sqlalchemy_athena.py -> PyAthena-1.7.0/tests
copying tests/util.py -> PyAthena-1.7.0/tests
Writing PyAthena-1.7.0/setup.cfg
Creating tar archive
removing 'PyAthena-1.7.0' (and everything under it)

And after introducing these changes we package this:

$ python setup.py sdist
running sdist
running egg_info
creating PyAthena.egg-info
writing PyAthena.egg-info/PKG-INFO
writing dependency_links to PyAthena.egg-info/dependency_links.txt
writing entry points to PyAthena.egg-info/entry_points.txt
writing requirements to PyAthena.egg-info/requires.txt
writing top-level names to PyAthena.egg-info/top_level.txt
writing manifest file 'PyAthena.egg-info/SOURCES.txt'
reading manifest file 'PyAthena.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'PyAthena.egg-info/SOURCES.txt'
running check
creating PyAthena-1.7.0
creating PyAthena-1.7.0/PyAthena.egg-info
creating PyAthena-1.7.0/pyathena
copying files to PyAthena-1.7.0...
copying LICENSE -> PyAthena-1.7.0
copying MANIFEST.in -> PyAthena-1.7.0
copying Pipfile -> PyAthena-1.7.0
copying Pipfile.lock -> PyAthena-1.7.0
copying README.rst -> PyAthena-1.7.0
copying setup.cfg -> PyAthena-1.7.0
copying setup.py -> PyAthena-1.7.0
copying PyAthena.egg-info/PKG-INFO -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/SOURCES.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/dependency_links.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/entry_points.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/not-zip-safe -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/requires.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying PyAthena.egg-info/top_level.txt -> PyAthena-1.7.0/PyAthena.egg-info
copying pyathena/__init__.py -> PyAthena-1.7.0/pyathena
copying pyathena/async_cursor.py -> PyAthena-1.7.0/pyathena
copying pyathena/async_pandas_cursor.py -> PyAthena-1.7.0/pyathena
copying pyathena/common.py -> PyAthena-1.7.0/pyathena
copying pyathena/connection.py -> PyAthena-1.7.0/pyathena
copying pyathena/converter.py -> PyAthena-1.7.0/pyathena
copying pyathena/cursor.py -> PyAthena-1.7.0/pyathena
copying pyathena/error.py -> PyAthena-1.7.0/pyathena
copying pyathena/formatter.py -> PyAthena-1.7.0/pyathena
copying pyathena/model.py -> PyAthena-1.7.0/pyathena
copying pyathena/pandas_cursor.py -> PyAthena-1.7.0/pyathena
copying pyathena/result_set.py -> PyAthena-1.7.0/pyathena
copying pyathena/sqlalchemy_athena.py -> PyAthena-1.7.0/pyathena
copying pyathena/util.py -> PyAthena-1.7.0/pyathena
Writing PyAthena-1.7.0/setup.cfg
creating dist
Creating tar archive
removing 'PyAthena-1.7.0' (and everything under it)

As you can see, no tests bundled! :)

Before this the tests would be installed alongside the package, meaning that
there'd be a global tests package installed alongside pyathena.

As a user of pyathena I don't need the tests in production and would rather 
not have them installed. :)
@laughingman7743 laughingman7743 merged commit 6bbd8fc into laughingman7743:master Jun 18, 2019
@laughingman7743
Copy link
Owner

@gaqzi Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants