fix: sqlx::macro db cleanup race condition by adding a margin to curr…

…ent timestamp (#2640)

* fix: sqlx::macro db cleanup race condition by adding a margin to current timestamp

* feat: increase margin to 2 seconds

sqlx-mysql/src/testing/mod.rs

@@ -176,11 +176,13 @@ async fn test_context(args: &TestArgs) -> Result<TestContext<MySql>, Error> {
 }
 
 async fn do_cleanup(conn: &mut MySqlConnection, created_before: Duration) -> Result<usize, Error> {
+    // since SystemTime is not monotonic we added a little margin here to avoid race conditions with other threads
+    let created_before_as_secs = created_before.as_secs() - 2;
     let delete_db_ids: Vec<u64> = query_scalar(
         "select db_id from _sqlx_test_databases \
             where created_at < from_unixtime(?)",
     )
-    .bind(&created_before.as_secs())
+    .bind(&created_before_as_secs)
     .fetch_all(&mut *conn)
     .await?;
 

sqlx-postgres/src/testing/mod.rs

@@ -183,7 +183,8 @@ async fn test_context(args: &TestArgs) -> Result<TestContext<Postgres>, Error> {
 }
 
 async fn do_cleanup(conn: &mut PgConnection, created_before: Duration) -> Result<usize, Error> {
-    let created_before = i64::try_from(created_before.as_secs()).unwrap();
+    // since SystemTime is not monotonic we added a little margin here to avoid race conditions with other threads
+    let created_before = i64::try_from(created_before.as_secs()).unwrap() - 2;
 
     let delete_db_names: Vec<String> = query_scalar(
         "select db_name from _sqlx_test.databases \