fix(sqlite): do not ignore API misuse errors from sqlite3_finalize

launchbadge · Apr 9, 2021 · 5cf1af2 · 5cf1af2
1 parent f488f53
commit 5cf1af2
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/sqlx-core/src/sqlite/statement/virtual.rs b/sqlx-core/src/sqlite/statement/virtual.rs
@@ -9,7 +9,7 @@ use crate::HashMap;
 use bytes::{Buf, Bytes};
 use libsqlite3_sys::{
     sqlite3, sqlite3_clear_bindings, sqlite3_finalize, sqlite3_prepare_v3, sqlite3_reset,
-    sqlite3_stmt, SQLITE_OK, SQLITE_PREPARE_PERSISTENT,
+    sqlite3_stmt, SQLITE_MISUSE, SQLITE_OK, SQLITE_PREPARE_PERSISTENT,
 };
 use smallvec::SmallVec;
 use std::i32;
@@ -201,7 +201,16 @@ impl Drop for VirtualStatement {
 
             unsafe {
                 // https://sqlite.org/c3ref/finalize.html
-                let _ = sqlite3_finalize(handle.0.as_ptr());
+                let status = sqlite3_finalize(handle.0.as_ptr());
+                if status == SQLITE_MISUSE {
+                    // Panic in case of detected misuse of SQLite API.
+                    //
+                    // sqlite3_finalize returns it at least in the
+                    // case of detected double free, i.e. calling
+                    // sqlite3_finalize on already finalized
+                    // statement.
+                    panic!("Detected sqlite3_finalize misuse.");
+                }
             }
         }
     }