Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): Add support for domain types description #1112

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

demurgos
Copy link
Contributor

@demurgos demurgos commented Mar 16, 2021

Fix commit updates the postgres::connection::describe module to add full support for domain types. Domain types were previously confused with their category which caused invalid oid resolution.

Fixes #110 #1110

@demurgos demurgos force-pushed the domain-type-description branch from 1eb3d41 to 4208d34 Compare March 16, 2021 18:21
Fix commit updates the `postgres::connection::describe` module to add full support for domain types. Domain types were previously confused with their category which caused invalid oid resolution.

Fixes launchbadge#110
@demurgos demurgos force-pushed the domain-type-description branch from 4208d34 to 93b90be Compare March 16, 2021 19:23
@demurgos
Copy link
Contributor Author

I am not sure why the GitHub checks fail with a communication error during compilation.

@mehcode
Copy link
Member

mehcode commented Apr 9, 2021

Thanks for this!

@mehcode mehcode merged commit fd828fe into launchbadge:master Apr 9, 2021
@demurgos
Copy link
Contributor Author

The commit message and original post erroneously linked to the issue #110. This is a typo: this commit fixes #1110.

demurgos added a commit to eternaltwin/etwin that referenced this pull request Oct 31, 2021
This commit uses a `sqlx` fork to use the fix from launchbadge/sqlx#1112.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants