Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounds on Connection::transaction are overly strict #1132

Conversation

argv-minus-one
Copy link
Contributor

The provided callback doesn't seem to need to be 'static. It seems to be enough that it doesn't borrow anything from the Connection itself, even if it does borrow data from elsewhere.

The provided callback doesn't need to be `'static`. It should be enough that it doesn't borrow anything from the `Connection` itself, even if it does borrow data from elsewhere.
@mehcode mehcode merged commit 2123d9d into launchbadge:master Apr 9, 2021
@mehcode
Copy link
Member

mehcode commented Apr 9, 2021

Fair point. Thank you.

@argv-minus-one argv-minus-one deleted the less-restrictive-connection-transaction branch April 26, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants