Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Any support for Local chrono datetime for MySQL #1224

Merged
merged 1 commit into from
May 21, 2021
Merged

Adding Any support for Local chrono datetime for MySQL #1224

merged 1 commit into from
May 21, 2021

Conversation

NatPRoach
Copy link
Contributor

Hello, a while back I put in a PR adding Any type support for chrono types. It seems I somehow missed that the mysql implementation supports chrono::DateTime<chrono::types::Local>. So this PR should add that support.

@mehcode mehcode merged commit db09cb6 into launchbadge:master May 21, 2021
@jplatte
Copy link
Contributor

jplatte commented Jun 14, 2021

Actually, CI for this failed with

the trait bound `DateTime<chrono::Local>: Type<MySql>` is not satisfied

@NatPRoach
Copy link
Contributor Author

Yeah @mehcode, I think you'll want to revert this PR given the CI problems. It looked like it should work based on the documentation but actually doesn't and doesn't compile if a certain set of features are used to compile. Very sorry for not bringing this up sooner.

@jplatte
Copy link
Contributor

jplatte commented Jun 21, 2021

Right, docs say that this type is supported for MySQL, but in reality it isn't. It looks like it would be easy to support, but I'm not 100% certain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants