Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "runtime-async-std-native-tls (on by default)"-hint #1485

Closed

Conversation

d4h0
Copy link

@d4h0 d4h0 commented Oct 9, 2021

It seems, the 'runtime-async-std-native-tls' feature isn't active by default (as mentioned in the README), so this PR removes the hint. Currently, users that don't use async-std might think they have to disable the default features to not pull-in async-std needlessly. But that doesn't seem to be required, because 'runtime-async-std-native-tls' isn't active by default.

It seems, the 'runtime-async-std-native-tls' feature isn't active by default (as mentioned in the README), so this PR removes the hint. Currently, users that don't use `async-std` might think they have to disable the default features to not pull-in `async-std` needlessly. But that doesn't seem to be required, because 'runtime-async-std-native-tls' isn't active by default.
@d4h0
Copy link
Author

d4h0 commented Oct 9, 2021

Looks like there is already a PR that fixes this (#1479).

@d4h0 d4h0 closed this Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant