feat(migration): add function to undo migrations #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrouet
force-pushed
the
jdrouet/sqlx-down-migration
branch
from
cdd5074 to
497ca52
Compare
jdrouet
force-pushed
the
jdrouet/sqlx-down-migration
branch
from
497ca52 to
3f72df2
Compare
|
There's not maintainer assigned automagically, so I'll ping you, I hope you won't mind. |
|
We get to PRs when we get to them. Pinging people on this repo is just going to fill up their notifications. |
jdrouet
force-pushed
the
jdrouet/sqlx-down-migration
branch
from
3f72df2 to
17273cb
Compare
|
I just rebased this PR on lastest master 😉 |
Right now, there is only a `run` function to programatically run the migrations, which is great, but nothing to run the migrations down. This function adds the possibility to undo the migrations until a specific version (could say -1 or 0 to remove them all). With this feature, it's now possible, in the end to end or integration tests to run the migrations and undo them between each test set and therefore test the migrations themselves. This is the kind of feature that some ORM have like sequelize in nodejs that allow you to undo migrations programatically. Reference to the doc: https://sequelize.org/v7/manual/migrations.html#undoing-migrations Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
jdrouet
force-pushed
the
jdrouet/sqlx-down-migration
branch
from
17273cb to
184f853
Compare
|
🎉 Thanks @abonander |
|
If you're ever bored, feel free to follow up on old issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, there is only a
runfunction to programatically run themigrations, which is great, but nothing to run the migrations down.
This function adds the possibility to undo the migrations until a
specific version (could say -1 or 0 to remove them all).
With this feature, it's now possible, in the end to end or integration
tests to run the migrations and undo them between each test set and
therefore test the migrations themselves.
This is the kind of feature that some ORM have like sequelize in nodejs
that allow you to undo migrations programatically.
Reference to the doc:
https://sequelize.org/v7/manual/migrations.html#undoing-migrations
Signed-off-by: Jérémie Drouet jeremie.drouet@gmail.com