-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Sqlite support for sub-queries and CTE's #1816
Conversation
…ual' integer value stored in the register by Integer/InitCoroutine/Yield operations.
…rather than unknown
Due to the size of the change, this could cause changes in the datatype for some queries. In particular:
Downsides of this approach include:
|
This feature seems to be causing very severe performance and correctness regression. Nullability inference doesn't seem to work nearly as well as previous versions. Replacing My main question is that is it really necessary to simulate all possible execution path? Meaning that can we reduce the search space by tracking unique |
Just for reference, the example query in this issue #1921 searched INSERT INTO x (a_id, b_id, c_id) VALUES ((SELECT 1 FROM a), (SELECT 2 FROM b), (SELECT 3 FROM c)) RETURNING id |
Improves the datatype and null tracking for sub-queries and common table expressions through a series of independent changes: