trim [ and ] from host string before used to connect by TcpStream #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
reviewed
Apr 21, 2022
smonv
force-pushed
the
fix/invalid-ipv6-host
branch
from
4c9fa90 to
204a65d
Compare
|
This would work, but what if the input contains multiple Seems unlikely though. |
smonv
force-pushed
the
fix/invalid-ipv6-host
branch
from
204a65d to
df5f827
Compare
smonv
force-pushed
the
fix/invalid-ipv6-host
branch
from
df5f827 to
970a427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I follow suggestion of @abonander and trim
[and]from host string before connectClose #1739