Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clone for PoolOptions #1919

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Implement Clone for PoolOptions #1919

merged 1 commit into from
Jun 22, 2022

Conversation

Thomasdezeeuw
Copy link
Contributor

To not break the API we need to use an Arc instead of a Box for the
callback functions. Alternatively we could require all the function to
be Clone, but that would be a breaking change.

To not break the API we need to use an Arc instead of a Box for the
callback functions. Alternatively we could require all the function to
be Clone, but that would be a breaking change.
@abonander abonander merged commit 39eadd6 into launchbadge:main Jun 22, 2022
@Thomasdezeeuw Thomasdezeeuw deleted the clone_for_pooloptions branch June 23, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants