fix: Remove default chrono dep on time for sqlx-cli #2089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Remove unnecessary dependency on
time
0.1 insqlx-cli
; that version oftime
is deprecated and contains a vulnerability flagged bycargo audit
.Effects of Change: This change adjusts the feature flags configured for the
chrono
crate forsqlx-cli
. It disables default features forchrono
and enables theclock
flag only. The outcome is thatchrono
will no longer include the defaultoldtime
feature flag which removes the dependency ontime
.Why?
time
0.1 is deprecated and vulnerable to RUSTSEC-2020-0071. Although chrono's dependency on time is not actually vulnerable, it causes cargo audit to be noisey:Unfortunately chrono 0.4.19 also generates noise with cargo audit, but 🤷