Expose PoolOptions for reading #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FSMaxB
force-pushed
the
read-pool-options
branch
from
246b1c0
to
5f11498
Compare
|
Force pushed because apparently my branch was on top of the outdated |
FSMaxB
force-pushed
the
read-pool-options
branch
2 times, most recently
from
ea8c691
to
c7282fe
Compare
|
@FSMaxB current development is on the |
This allows reading back PoolOptions that have already been set.
FSMaxB
force-pushed
the
read-pool-options
branch
from
c7282fe
to
3ebb856
Compare
@abonander done! |
FSMaxB
force-pushed
the
read-pool-options
branch
from
972272a
to
3ebb856
Compare
|
@abonander If |
abonander
pushed a commit
that referenced
this pull request
Feb 18, 2023
This allows reading back PoolOptions that have already been set.
abonander
pushed a commit
that referenced
this pull request
Feb 21, 2023
This allows reading back PoolOptions that have already been set.
Aandreba
pushed a commit
to Aandreba/sqlx
that referenced
this pull request
Mar 31, 2023
This allows reading back PoolOptions that have already been set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows reading back
PoolOptionsthat have already been set.My concrete use-case is querying the maximum connections from a context where I regularly collect application performance metrics from a
PgPool. Currently I can only see how many connections there are and how many of them are active/idle, but in order to graph this against the totally available connections, I would have to pass through the initial configuration somehow. It's much easier to expose them from thePoolOptionsdirectly.