fix: use owned Builder pattern for ConnectOptions #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR changed to target |
|
Thank you @abonander 🙌🏻 |
|
@ar3s3ru no need to update |
|
@abonander rebased on latest commit on Welcome back btw! |
|
@ar3s3ru if you amend and force-push it should trigger a CI run. |
grgi
pushed a commit
to faccts/sqlx
that referenced
this pull request
Feb 14, 2023
* CHANGELOG: mention that users should upgrade CLI * fix(sqlx-core): use owned builder pattern for ConnectOptions --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
abonander
added a commit
that referenced
this pull request
Feb 18, 2023
* CHANGELOG: mention that users should upgrade CLI * fix(sqlx-core): use owned builder pattern for ConnectOptions --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
abonander
added a commit
that referenced
this pull request
Feb 21, 2023
* CHANGELOG: mention that users should upgrade CLI * fix(sqlx-core): use owned builder pattern for ConnectOptions --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Aandreba
pushed a commit
to Aandreba/sqlx
that referenced
this pull request
Mar 31, 2023
* CHANGELOG: mention that users should upgrade CLI * fix(sqlx-core): use owned builder pattern for ConnectOptions --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2131