Sqlite describe fixes #2253
Merged
Sqlite describe fixes #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compilation will fail until #2199 is merged. |
… Allow instructions to be executed a small number of times to fix nested order by query
…m a recursive query
tyrelr
force-pushed
the
sqlite_describe_fixes
branch
from
21e93ff to
1d7d50a
Compare
abonander
pushed a commit
that referenced
this pull request
Feb 18, 2023
* add failing test for nested orderby * log query paths which were abandoned due to invalid state or looping. Allow instructions to be executed a small number of times to fix nested order by query * add failing testcase using nested orderby * fix handling of sequence/offset and rewind * fix handling when sqlite nests records inside of records * add test of temporary table handling * WIP add test failure for temp table access * fix support for temp tables * add tests for sqlite datetime functions * add basic date and time function support * handle gosub opcode correctly * add group by test * fix group by handling * add additional passing group by test * add test case for simple limit query * fix IfPos & If touching wrong branches state, fix IfPos using wrong branch criteria * add test for large offsets * add short-circuit for possible query offset loops * add groupby query that is predicted incorrectly * fix handling of integer cast failures * add tests for single-row aggregate results * fix handling of null-based branching * add test for coercion of text by sum * fix calculation of sum value coercion * add failing test for recursive with query * add logic for delete operation to fix queries grouping by columns from a recursive query
abonander
pushed a commit
that referenced
this pull request
Feb 21, 2023
* add failing test for nested orderby * log query paths which were abandoned due to invalid state or looping. Allow instructions to be executed a small number of times to fix nested order by query * add failing testcase using nested orderby * fix handling of sequence/offset and rewind * fix handling when sqlite nests records inside of records * add test of temporary table handling * WIP add test failure for temp table access * fix support for temp tables * add tests for sqlite datetime functions * add basic date and time function support * handle gosub opcode correctly * add group by test * fix group by handling * add additional passing group by test * add test case for simple limit query * fix IfPos & If touching wrong branches state, fix IfPos using wrong branch criteria * add test for large offsets * add short-circuit for possible query offset loops * add groupby query that is predicted incorrectly * fix handling of integer cast failures * add tests for single-row aggregate results * fix handling of null-based branching * add test for coercion of text by sum * fix calculation of sum value coercion * add failing test for recursive with query * add logic for delete operation to fix queries grouping by columns from a recursive query
Aandreba
pushed a commit
to Aandreba/sqlx
that referenced
this pull request
Mar 31, 2023
* add failing test for nested orderby * log query paths which were abandoned due to invalid state or looping. Allow instructions to be executed a small number of times to fix nested order by query * add failing testcase using nested orderby * fix handling of sequence/offset and rewind * fix handling when sqlite nests records inside of records * add test of temporary table handling * WIP add test failure for temp table access * fix support for temp tables * add tests for sqlite datetime functions * add basic date and time function support * handle gosub opcode correctly * add group by test * fix group by handling * add additional passing group by test * add test case for simple limit query * fix IfPos & If touching wrong branches state, fix IfPos using wrong branch criteria * add test for large offsets * add short-circuit for possible query offset loops * add groupby query that is predicted incorrectly * fix handling of integer cast failures * add tests for single-row aggregate results * fix handling of null-based branching * add test for coercion of text by sum * fix calculation of sum value coercion * add failing test for recursive with query * add logic for delete operation to fix queries grouping by columns from a recursive query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reproducers & fixes for various sqlite describe bugs.
Fixes include: