-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set whoami default-features to false #2319
Conversation
Does not look like the CI failures are due to the changes in this PR. |
@thedodd current development is on the |
Base changed to |
9feec26
to
a5dbecf
Compare
Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps.
dependencies = [ | ||
"wasm-bindgen", | ||
"web-sys", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful.
@abonander this should be ready to rock now. |
* Fixed typo. (launchbadge#2156) * Set whoami default-features to false Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps. --------- Co-authored-by: Chris Foster <cdbfoster@gmail.com>
* Fixed typo. (#2156) * Set whoami default-features to false Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps. --------- Co-authored-by: Chris Foster <cdbfoster@gmail.com>
* Fixed typo. (#2156) * Set whoami default-features to false Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps. --------- Co-authored-by: Chris Foster <cdbfoster@gmail.com>
* Fixed typo. (launchbadge#2156) * Set whoami default-features to false Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps. --------- Co-authored-by: Chris Foster <cdbfoster@gmail.com>
Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps.