fix: Decode and Encode derives (#1031) #2329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
main
branch
2 times, most recently
from
6cf15b0 to
eade49c
Compare
|
@benluelo can you fix the merge conflicts? |
|
Closing due to inactivity. Feel free to reopen if you come back to this. |
|
I'm unable to reopen this, but I've rebased off of the latest main so this should be good to go! |
|
Any update on this? |
|
@benluelo I'm so sorry, I didn't realize that if I closed a PR the author wouldn't be able to reopen it. It won't let me reopen it either now that you've pushed to the branch so feel free to open a new PR. |
|
No worries - I've opened a new pr (#2940) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1031.
I'm planning on adding some ui tests for the macros in the next few days 👍I will open a follow-up PR with said UI tests as that is a much larger change.Question - is there is any good way to test the whole workspace with the entire (valid) feature matrix?