cli: add --target-version CLI flags for migrate run/revert #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@inahga sorry for the delay looking at this but it looks like there's some merge conflicts that need to be resolved. |
After some discussion with my coworkers, we thought about the behavior a bit more: The behavior is now that for a run, if the provided version is too old, the CLI will return with failure rather than being a no-op. This gives feedback to the operator instead of being quiet. It is still valid to up/downgrade to the latest version, this will still be a no-op to allow for idempotency.
|
No worries. I've rebased on the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2534. See issue for detailed description of the purpose.
Adds a
--target-versionflag formigrate {run,revert}, which tells the command to apply any number of migrations to get to the provided schema version. The CLI will provide feedback on any migrations that were skipped due to the flag.I went ahead and setup a basic test harness and CI for the CLI, where none seemed to exist before (let me know if I'm mistaken). It is optional--I thought it might be helpful. If not, the commit can be dropped.