Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres): PgHasArrayType is not implemented for Vec<i64> #2617

Closed
wants to merge 1 commit into from
Closed

fix(postgres): PgHasArrayType is not implemented for Vec<i64> #2617

wants to merge 1 commit into from

Commits on Jul 14, 2023

  1. fix(postgres): PgHasArrayType is not implemented for Vec<i64> 

    caused by launchbadge#2086
closes launchbadge#2611

seems like launchbadge#2086 fixed issue described by @Wopple by making that block
of code unreachable. Not as it was stated in
> Problem: PgHasArrayType was checking the application's postgres feature
> Solution: only check the library's postgres feature

after checking https://doc.rust-lang.org/std/macro.cfg.html
> `cfg!`, unlike `#[cfg]`, does not remove any code and only evaluates
> to true or false. For example, all blocks in an if/else expression
> need to be valid when `cfg!` is used for the condition, regardless of
> what `cfg!` is evaluating.

so to my understanding it would be `true` anyway in @woople scenario
    @mrl5
    mrl5 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    ed8cf98 View commit details
    Browse the repository at this point in the history