-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for setting client certificate and key from bytes #2646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These methods should use _from_pem()
instead of _from_bytes()
to match:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation and examples could be clearer.
Ugh, every time I try to commit suggestions to a PR I end up breaking it more, lol. I'll fix it. |
This PR adds
ssl_client_cert_from_bytes
andssl_client_key_from_bytes
toMySQL
andPostgreSQL
.This will allow slqx to configure tls cert without going through the filesystem. This can be useful in certain scenarios, such as reading certificates from Keychain.