Chore: Fix few build warnings, and make CI fail on warn #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
err-on-warn
branch
3 times, most recently
from
18044b5 to
794b0de
Compare
nyurik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few warnings and make it so that all
cargo buildandcargo checkin CI generate errors if they encounter warnings. This will ensure cleaner code, and won't hide warnings (they tend to hide if CI doesn't show them as failures)This PR also fixes example CI -
Chat (Check)had a yaml error and misnamed target.Note that
cargo teststill generates a lot of warnings, but they don't trigger build failure