Constrain cyclic associated types to themselves #2702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Database
trait's associated types are constrained usingConnection<Database = Self>
but this constraint is not specified for the reverseDatabase<Connection = Self>
. This causes issues when wrapping or "extending" sqlx traits since as far as rust's type system is concernedSelf::Connection::Database::Connection != Self::Connection
.Consider the following example:
This PR adds bounds such that cyclic associated types are equal to themselves.