Implement PgHasArrayType for all references #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense but unfortunately I think it's a breaking change. Since references are fundamental, there might be code out there that has already manually implemented |
|
You're right. Can we get it into the 0.8 version? |
|
Yeah, we'll get it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
No, I can open one if necessary.
I was trying to implement an iterator type that I can use to bind so that I can use
unnestfor large inserts and simplify the existing code a lot. The problem I ran into is that&DateTime<Utc>and&BigDecimaldon't implement PgHasArrayType even though they should trivially be able to with a generic impl. This fixes that.The deleted overlapping impl will still have the same PgTypeInfo returned.