Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debug impl for PgRow #2917

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add Debug impl for PgRow #2917

merged 1 commit into from
Apr 22, 2024

Conversation

g-bartoszek
Copy link
Contributor

fixes #150

Adds partial Debug impl for PgRow. Utilises a mapping between PgType variants and types. For the variants for which the mapping is not defined falls back to string or binary representation.

sqlx-postgres/src/row.rs Outdated Show resolved Hide resolved
abonander added a commit that referenced this pull request Jan 6, 2024
abonander added a commit that referenced this pull request Jan 6, 2024
abonander added a commit that referenced this pull request Jan 16, 2024
abonander added a commit that referenced this pull request Jan 16, 2024
abonander added a commit that referenced this pull request Jan 16, 2024
abonander added a commit that referenced this pull request Mar 14, 2024
abonander added a commit that referenced this pull request Mar 30, 2024
@abonander
Copy link
Collaborator

@g-bartoszek would you please rebase and fix conflicts? We're now ready to merge this.

@g-bartoszek
Copy link
Contributor Author

@g-bartoszek would you please rebase and fix conflicts? We're now ready to merge this.

@abonander sure, will do

g-bartoszek pushed a commit to g-bartoszek/sqlx that referenced this pull request Mar 31, 2024
@g-bartoszek g-bartoszek force-pushed the dbg-impl branch 2 times, most recently from 66759f7 to 2db34c5 Compare March 31, 2024 16:46
sqlx-postgres/src/row.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit, sorry.

sqlx-postgres/src/row.rs Outdated Show resolved Hide resolved
@abonander
Copy link
Collaborator

CI failure is due to a change to the runner image. I've fixed it on main.

@abonander abonander merged commit a5d7fff into launchbadge:main Apr 22, 2024
62 checks passed
jayy-lmao pushed a commit to jayy-lmao/sqlx that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Debug impl for <DB>Row
2 participants