chore(deps): Add deny.yaml and a cargo deny CI job to check dependencies #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made the |
iamjpotts
force-pushed
the
20240122-cargo-deny
branch
3 times, most recently
from
c0f6b85 to
1ed24b5
Compare
|
Moved |
|
Moved |
iamjpotts
force-pushed
the
20240122-cargo-deny
branch
2 times, most recently
from
86567fc to
b3c2400
Compare
iamjpotts
force-pushed
the
20240122-cargo-deny
branch
from
b3c2400 to
e63b3b7
Compare
iamjpotts
force-pushed
the
20240122-cargo-deny
branch
from
e63b3b7 to
3a0415a
Compare
iamjpotts
force-pushed
the
20240122-cargo-deny
branch
from
3a0415a to
57217f7
Compare
…ies for vulnerabilities Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
iamjpotts
force-pushed
the
20240122-cargo-deny
branch
from
57217f7 to
259fe4f
Compare
|
Related: #1297 |
|
I'm not super interested in this. Too many RUSTSEC advisories are filed for trivial things like crates being unmaintained (it's only an issue if there's also high-impact bugs and PRs aren't getting merged) and our CI breaks enough as it is. Weak features in Cargo also result in a lot of false-positives (#3211). For issues that really matter, people are pretty quick to call them out or open a PR anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo denychecks for dependencies with vulnerabilities, vulnerability advisories, unmaintained crates, duplicate dependencies, and other issues.deny.yamllicenselinelicense = "MIT OR Apache-2.0"tosqlx-testcrate to satisfy license checker. This license spec matches what is already in the workspaceCargo.tomlfilesqlx-testcrate to referencesqlxcrate viaworkspace=truerather than a path`Cargo.tomlat workspace root to referencesqlx-testusing its version number