-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mysql): allow to connect with mysql driver without default behavor #3037
Conversation
My disposition is still the same as in #2389 (comment) I'd prefer to add toggles/setters for the individual options, because the defaults all have specific reasons for existing. |
You're right, that's probably more sensitive. I have implemented the setters (although I'm not 100% convinced about the naming) and adapted the connection behavior accordingly (although I'm using more Heap allocations to gain better readability, but I can change that to a single String again, if that is preferred). The comment above the old implementation mentions setting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One documentation change and one API change.
…nnecting docs(mysql): improve docs for options set_names and no_engine_substitution
Thanks. I have updated the Edit: the Edit2: maybe |
I'm happy with this as it is. |
Hi, I ran into some issues connecting with a MariaDB Instance behind ProxySQL (I would guess, that the Variables are not replicated correctly to the cluster).
I don't have any access to the Database or the Logs and thus can't debug that much but found out, that the only differences to other MySQL Drivers are the Parameters set after connecting to the Instance.
I have found this Issue #2389 and after hacking around a bit, I found that turning off the initialization "fixes" my problem.
This PR gives an option to disable the Default Behavior after connecting. I haven't touched the defaults, so there should be no breaking behavior.