Add version information for failed cli migration (#3129) #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
approved these changes
Mar 30, 2024
FlakM
force-pushed
the
mf_add_version_info_cli
branch
from
cb6add5 to
4d41cdc
Compare
|
Hi, thanks for reviewing. I've rebased on current main - the CI/CD was failing for some unrelated reason. |
|
There is absolutely no rush but CI seems to fail due to unrelated reasons: |
|
Already fixed on |
|
Nevermind, rerun worked. |
|
@abonander awesome! I'd also love to take this time to thank you for maintaining sqlx. I enjoy working with it, and I know it must be a huge burden to take care of a project of this size. Thank you! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Yes - it shows following output:
fixes #3129