Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time to 0.3.36 #3190

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Update time to 0.3.36 #3190

merged 3 commits into from
Apr 12, 2024

Conversation

BlackSoulHub
Copy link
Contributor

fixes #3189

@billy1624
Copy link
Contributor

Thanks!! @BlackSoulHub

@svix-jplatte
Copy link

svix-jplatte commented Apr 10, 2024

I'm not sure if this is a good idea, I could see that release be yanked because of the breaking change. Upstream issue: time-rs/time#675

@gilgabo
Copy link

gilgabo commented Apr 10, 2024

Hi @BlackSoulHub / @svix-jplatte , do you have any update about this issue (we have a couple of releases and our CICD pipelines blocked by this change)? 😟

@jhpratt
Copy link

jhpratt commented Apr 10, 2024

@svix-jplatte I assure you that the release will not be yanked. There will almost certainly be a follow-up release, though.

@BlackSoulHub
Copy link
Contributor Author

Hi @BlackSoulHub / @svix-jplatte , do you have any update about this issue (we have a couple of releases and our CICD pipelines blocked by this change)? 😟

fixed in time crate
(time-rs/time@3c3c546)

@BlackSoulHub
Copy link
Contributor Author

I'm not sure if this is a good idea

Maybe update time version to 0.3.36?
Or this changes broke something?

@svix-jplatte
Copy link

My comment has been resolved by jhpratt's reply. I don't think it really matters whether the upgrade goes to 0.3.35 or 0.3.36, both should be fine.

@BlackSoulHub
Copy link
Contributor Author

My comment has been resolved by jhpratt's reply. I don't think it really matters whether the upgrade goes to 0.3.35 or 0.3.36, both should be fine.

Ok. I update version to 0.3.36

@BlackSoulHub BlackSoulHub changed the title Update time to 0.3.35 Update time to 0.3.36 Apr 11, 2024
@abonander abonander merged commit 6a4f61e into launchbadge:main Apr 12, 2024
62 checks passed
jayy-lmao pushed a commit to jayy-lmao/sqlx that referenced this pull request Jun 6, 2024
* update time to 0.3.35

* fmt fix

* update version to 0.3.36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading time crate to 0.3.35
6 participants