fix: sqlite update_hook char types #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonish please rebase and run |
jasonish
force-pushed
the
sqlite/arm/fixup/v1
branch
from
915f8df to
d1be318
Compare
|
@jasonish sorry, one more rebase and CI should go green. |
Use "c_char" instead of "i8" as it resolves to the correct string type on different architectures. Fixes: launchbadge#3287
jasonish
force-pushed
the
sqlite/arm/fixup/v1
branch
from
d1be318 to
4dbdff5
Compare
abonander
approved these changes
Jul 20, 2024
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
Use "c_char" instead of "i8" as it resolves to the correct string type on different architectures. Fixes: launchbadge#3287
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
Use "c_char" instead of "i8" as it resolves to the correct string type on different architectures. Fixes: launchbadge#3287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "c_char" instead of "i8" as it resolves to the correct string type on different architectures.
Fixes: #3287