Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:the json-feature should activate sqlx-postgres?/json as well #3350

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

CommanderStorm
Copy link
Contributor

As discussed (or more accurately missed by me), the json feature should also activate the postgres' related json feature.

(I thought that you might like this as a PR as this is simpler for you to accept. If you want your commit in your name, that is fine too ^^)

Before After
image image

Does your PR solve an issue?

Fixes #3316

sqlx-macros-core/Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
@abonander abonander merged commit 08e45f4 into launchbadge:main Jul 16, 2024
65 checks passed
@CommanderStorm CommanderStorm deleted the postgres-json branch July 17, 2024 01:02
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
…aunchbadge#3350)

* fix: made sure that the json feature is defined for postgres as well

* fixed the feature order

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>

---------

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
…aunchbadge#3350)

* fix: made sure that the json feature is defined for postgres as well

* fixed the feature order

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>

---------

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional sqlx feature json required for type JSONB of column/param X
2 participants