Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct spelling of MySqlConnectOptions::no_engine_substitution() #3421

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

kolinfluence
Copy link
Contributor

@kolinfluence kolinfluence commented Aug 9, 2024

Does your PR solve an issue?

no_engine_subsitution is named wrongly. giving a lot of issues when working with ai.

replaced
no_engine_subsitution
to
no_engine_substitution

correct naming no_engine_substitution
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that this isn't a breaking change, leave the old method in-place and mark it #[deprecated = "renamed to `.no_engine_substitution()`"]

@kolinfluence
Copy link
Contributor Author

So that this isn't a breaking change, leave the old method in-place and mark it #[deprecated = "renamed to `.no_engine_substitution()`"]

@abonander ok. added. pls check again

@abonander abonander changed the title no_engine_substitution correction. as corrected and use with ai correct spelling of MySqlConnectOptions::no_engine_substitution() Aug 9, 2024
@kolinfluence
Copy link
Contributor Author

@abonander @CommanderStorm ok done

@abonander abonander merged commit fac53b0 into launchbadge:main Aug 12, 2024
86 checks passed
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
…aunchbadge#3421)

* Update connect.rs

* Update mod.rs

correct naming no_engine_substitution

* Update mod.rs

* Update mod.rs

* Update mod.rs

* Update mod.rs
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
…aunchbadge#3421)

* Update connect.rs

* Update mod.rs

correct naming no_engine_substitution

* Update mod.rs

* Update mod.rs

* Update mod.rs

* Update mod.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants