New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LRU Statement Caching #444

Merged

mehcode merged 7 commits into launchbadge:master from pimeys:lru

Jun 25, 2020

Contributor

pimeys commented Jun 24, 2020 •

edited

Loading

This implements statement caches in connectors using a least recently used caching (LRU).

Addresses issue #145

pimeys commented

View reviewed changes

sqlx-core/src/caching_connection.rs Outdated Show resolved Hide resolved

pimeys commented

View reviewed changes

sqlx-core/src/mysql/options.rs Outdated Show resolved Hide resolved

pimeys commented

View reviewed changes

sqlx-core/src/mysql/options.rs Outdated Show resolved Hide resolved


          LRU statement cache for MySQL

2b6f242

pimeys force-pushed the lru branch from 54d6828 to 2b6f242 Compare

June 24, 2020 14:57


          LRU caching for PostgreSQL

5d64310

pimeys force-pushed the lru branch from 2c9c828 to 5d64310 Compare

June 24, 2020 17:02

pimeys commented

View reviewed changes

sqlx-core/src/postgres/connection/mod.rs Outdated Show resolved Hide resolved


          LRU caching for SQLite

eba82e3

pimeys force-pushed the lru branch from 3ef98fb to eba82e3 Compare

June 24, 2020 17:46

pimeys commented

View reviewed changes

sqlx-core/src/sqlite/options.rs Outdated Show resolved Hide resolved

pimeys changed the title ~~WIP: LRU Statement Caching~~ LRU Statement Caching

Member

mehcode commented Jun 25, 2020

Looks pretty good to me. Do you think we could add support for a cache capacity of zero (e.g., disabling the cache) with this?

Bit of a bikeshedd but how about statement_cache_capacity instead of statement_cache_size for the option name?


          Caching methods in Connection

2c2a277

pimeys force-pushed the lru branch from aebe8ac to 2c2a277 Compare

June 25, 2020 08:44

Julius de Bruijn added 3 commits

June 25, 2020 11:57


          Document new connection string params

f969798


          Close pg statements correctly

745a32a


          No need to reset the statement when dropping.

363dbfb

mehcode merged commit 8600e5d into launchbadge:master

pimeys mentioned this pull request

use better-sqlite3 as sqlite database driver (or provide the option) prisma/prisma#2825

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet