Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: chrono for SQLite, rebasing @felipesere + more #458

Merged
merged 9 commits into from
Jul 4, 2020

Conversation

meteficha
Copy link
Contributor

Hello!

This pull request rebases #230, fixes it to work on master, adds support to DateTime<Utc> and DateTime<Local>, and adds a few tests.

Copy link
Member

@mehcode mehcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks for picking this up. It looks good to me. Can you add support for INTEGER and REAL storage formats as well?

sqlx-core/src/sqlite/types/chrono.rs Show resolved Hide resolved
@mehcode mehcode merged commit 7d22c09 into launchbadge:master Jul 4, 2020
@mehcode
Copy link
Member

mehcode commented Jul 4, 2020

Thanks again for picking this up. I added support for NaiveDate and NaiveTime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants