Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support for #[sqlx(default)] #495

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

OriolMunoz
Copy link
Contributor

Closes #308

I'm not used to doing stuff with macros, but this seemed easy enough to give it a try.
Still needs documentation, more tests? (where?) and whatever fixes are necessary 😃

@mehcode
Copy link
Member

mehcode commented Jul 12, 2020

This looks pretty good. Thank you for working on it. The FromRow trait documentation needs a bit of work to talk about the different attributes, see here: https://github.com/launchbadge/sqlx/blob/master/sqlx-core/src/from_row.rs#L8

If that's something you want to work on, please go ahead ❤️ . I'll go ahead and merge this though as its a nice bump forward. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[derive(FromRow)] should support columns which may be omitted from the result set
2 participants