Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrate! macro with no params #762

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Conversation

esemeniuc
Copy link
Contributor

Fixes issue experienced in #746 when using no parameter:

error: paths relative to the current file's directory are not currently supported
 --> src/db.rs:7:5
  |
7 |     sqlx::migrate!().run(&conn).await?;
  |     ^^^^^^^^^^^^^^^^
  |
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

Fixes issue experienced in launchbadge#746 when using no parameter:

```
error: paths relative to the current file's directory are not currently supported
 --> src/db.rs:7:5
  |
7 |     sqlx::migrate!().run(&conn).await?;
  |     ^^^^^^^^^^^^^^^^
  |
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
```
@esemeniuc esemeniuc changed the title Fixes migration macro with no params Fixes migrate! macro with no params Oct 22, 2020
@esemeniuc esemeniuc changed the title Fixes migrate! macro with no params Fix migrate! macro with no params Oct 22, 2020
@izik1
Copy link
Contributor

izik1 commented Oct 22, 2020

LGTM on CI completion.
For future work ideally we make the ./ prefix redundant, but that's forward compatible so no big deal.
I'll open an issue for that after this is merged

@mehcode mehcode merged commit abb7112 into launchbadge:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants