Fixing PostgreSQL BigDecimal conversion problems #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a fix too, that borrows from the |
|
Maybe @abonander could take a look and see if this makes any sense? |
pimeys
force-pushed
the
bigdecimal-bug
branch
from
2c18ac2 to
a28455e
Compare
pimeys
changed the title
Now working properly with numbers, such as `0.01` and `0.012`.
pimeys
force-pushed
the
bigdecimal-bug
branch
from
a28455e to
0c1a3c5
Compare
|
I don't really have the brain cycles to go through the math but the added test cases proves well enough to me that it's more correct than what was there before. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails. Expecting
0.01, got0.