Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare 5.0.3 release #232

Merged
merged 45 commits into from
Feb 2, 2024
Merged

prepare 5.0.3 release #232

merged 45 commits into from
Feb 2, 2024

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    1aa5822 View commit details
    Browse the repository at this point in the history
  2. Removes check out

    ember-stevens committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    eb7d510 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6692363 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Contexts autopopulated with application and device information withou…

    …t collision handling nor testing.
    tanderson-ld committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    07d822a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Configuration menu
    Copy the full SHA
    1441a1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b62f48e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cc44ac1 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Configuration menu
    Copy the full SHA
    7fa4f9d View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Configuration menu
    Copy the full SHA
    0136dda View commit details
    Browse the repository at this point in the history
  2. feat: core implementation of auto environment attributes (#298)

    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [x] I have validated my changes against all supported platform
    versions.
    
    **Related issues**
    
    [Provide links to any issues in this repository or elsewhere relating to
    this pull request.
    
    ](https://app.shortcut.com/launchdarkly/story/204369/core-telemetry-in-android-sdk)
    
    **Describe the solution you've provided**
    
    See
    https://github.com/launchdarkly/sdk-specs/blob/ta/sc-203619/auto-env-attributes-software-specs/specs/CONTEXTENVDATA-context-environment-data/ImplementationGuidance.md#object-oriented-sdks-with-persistence
    
    **Describe alternatives you've considered**
    
    See
    https://launchdarkly.atlassian.net/wiki/spaces/PD/pages/2426306660/Mobile+Telemetry+Brainstorming+Investigation#Implementation-Ideas
    tanderson-ld authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f358aeb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af85026 View commit details
    Browse the repository at this point in the history
  4. Add file CODEOWNERS (#299)

    This pull request was auto generated by the Launchdarkly Github
    Standards automation platform.
    
    * Add default CODEOWNERS file
    kparkinson-ld authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    a277bc6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. WIP

    tanderson-ld committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    dad79ce View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    3874ef3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e59f81 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5026a89 View commit details
    Browse the repository at this point in the history
  4. Ta/sc 204374/auto env opt in (#300)

    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [x] I have validated my changes against all supported platform
    versions
    
    **Related issues**
    
    
    https://app.shortcut.com/launchdarkly/story/204374/android-telemetry-add-opt-in-out-support
    
    **Describe the solution you've provided**
    
    Piped boolean through config and contract testing layers into LDClient's
    use of context modifiers.
    
    **Describe alternatives you've considered**
    
    None others strongly considered, current solution is pretty much the
    minimal solution.
    tanderson-ld authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4646768 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    80cd412 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Added name to the OS object in ld_device recipe. (#301)

    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [x] I have validated my changes against all supported platform
    versions.
    
    **Related issues**
    
    
    https://app.shortcut.com/launchdarkly/story/208999/android-telemetry-implement-new-os-attribute-spec
    
    **Describe the solution you've provided**
    
    OS Name will take the form of "Android<SDKINT>".  Example: Android21
    
    **Describe alternatives you've considered**
    
    Android API 23 (too wordy)
    Android M (multiple ways to get the Letter code for the OS across
    different API levels, not worth the difficulty to implement. Also,
    they're going to run out of Letters, so seems risky over the next 5
    years).
    tanderson-ld authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    dff5018 View commit details
    Browse the repository at this point in the history
  2. Adding deterministic ld_application key generation to recipe and also…

    … moved locale from ld_device to ld_application
    tanderson-ld committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    add8304 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Adding deterministic ld_application key generation to recipe and also…

    …… (#302)
    
    … moved locale from ld_device to ld_application
    
    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [x] I have validated my changes against all supported platform
    versions
    
    **Related issues**
    
    
    https://app.shortcut.com/launchdarkly/story/208863/android-telemetry-stable-ld-application-key
    
    **Describe the solution you've provided**
    
    Updated callable of the ld_application recipe.
    
    **Describe alternatives you've considered**
    
    Could have done a large closure for creating each context instead of
    having recipes, but there would be duplicated code related to iterating
    over the attributes and handling set failures. That seemed like a big
    enough con to dissuade me from doing that.
    tanderson-ld authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b1d8c79 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    1198f9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff596c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Added autoEnvAttributes required parameter to LDConfig. Adjusted rel……

    … (#303)
    
    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [x] I have validated my changes against all supported platform
    versions
    
    **Related issues**
    
    
    https://app.shortcut.com/launchdarkly/story/204374/android-telemetry-add-opt-in-out-support
    
    **Describe the solution you've provided**
    
    In the next major version, customers must make a decision on whether to
    opt in/out of env attributes. A required parameter on the LDConfig
    constructor was chosen during the SDK technical discussion. The required
    parameter is an enum type for extra API clarity.
    
    **Describe alternatives you've considered**
    
    Other ideas considered during the SDK technical discussion
    
    a fluent builder with multiple types to control when the build()
    function can be called.
    alternative SDKs for the feature (possible, but high maintenance costs)
    tanderson-ld authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5ce1735 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    ede22d8 View commit details
    Browse the repository at this point in the history
  2. Feature/auto attributes (#305)

    Merging feature branch into 5.x branch.
    tanderson-ld authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d2478c7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e9378f6 View commit details
    Browse the repository at this point in the history
  4. Deprecating LDUser and related functionality. (#304)

    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [x] I have validated my changes against all supported platform
    versions
    
    **Related issues**
    
    
    https://app.shortcut.com/launchdarkly/story/210352/android-add-deprecation-warnings-for-lduser-functionality
    tanderson-ld authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    74bb9cb View commit details
    Browse the repository at this point in the history
  5. merge from public after release

    LaunchDarklyReleaseBot committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0c78ca7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f4c4661 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4742f96 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dcca763 View commit details
    Browse the repository at this point in the history
  9. Removing previously deprecated LDUser and related functionality. (#306)

    **Requirements**
    
    - [ ] I have added test coverage for new or changed functionality
    Only removing code, so not additional coverage.
    
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [x] I have validated my changes against all supported platform
    versions
    
    **Related issues**
    
    
    https://app.shortcut.com/launchdarkly/story/210354/android-remove-lduser-in-the-auto-env-branch
    
    **Describe the solution you've provided**
    
    Pew, pew, pewwww, pew pew.  Die LDUser, die!
    tanderson-ld authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9f46680 View commit details
    Browse the repository at this point in the history
  10. Updating env attributes spec version to 1.0 for production release. (…

    …#307)
    
    Documentation pass found one version that needed to be updated.
    tanderson-ld authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b162aa3 View commit details
    Browse the repository at this point in the history
  11. 5.x (#308)

    Just propagating into main.
    tanderson-ld authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    081d283 View commit details
    Browse the repository at this point in the history
  12. merge from public after release

    LaunchDarklyReleaseBot committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a76ed9b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. fix: updating sanitization, validation, and fallback logic of Auto En…

    …v Attributes to be more consistent and user friendly.
    tanderson-ld committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    9b1d1ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3071d45 View commit details
    Browse the repository at this point in the history
  3. Update launchdarkly-android-client-sdk/src/test/java/com/launchdarkly…

    …/sdk/android/LDUtilTest.java
    
    Co-authored-by: Matthew M. Keeler <keelerm84@gmail.com>
    tanderson-ld and keelerm84 authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    5f2bbf9 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Configuration menu
    Copy the full SHA
    68b1b70 View commit details
    Browse the repository at this point in the history
  2. fix: updating sanitization, validation, and fallback logic of Auto En…

    …… (#309)
    
    Need to merge test harness changes before this will pass.
    
    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [x] I have validated my changes against all supported platform
    versions
    
    **Related issues**
    
    
    https://app.shortcut.com/launchdarkly/story/213112/inconsistent-applicationname-and-applicationversionname-validation
    
    **Describe the solution you've provided**
    
    - Added sanitization logic to application info fields where spaces are
    now converted to hyphens. This is to help customers create values that
    will be accepted by our cloud infrasturcture.
    - Updated fallback logic to fallback to next source of application info
    if the applicationID is invalid. This invalid ID would be rejected by
    the cloud, so making that consistent.
    - Fixing bug in hashing to calulcate ld_application key where an omitted
    version would actually result in hash("myID:nil") when it should have
    been hash("myID:")
    
    **Describe alternatives you've considered**
    
    See:
    https://launchdarkly.atlassian.net/wiki/spaces/~63fb3c420d9b61193c23bde7/pages/2544828779/213112+-+Consistent+application+info+validation
    tanderson-ld authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    9e2c786 View commit details
    Browse the repository at this point in the history
  3. merge from public after release

    LaunchDarklyReleaseBot committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    54474f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. fix: Change the ld_application id generation logic (#310)

    We have discussed and agreed to modify the logic to not include the
    version as the context key generation. We will release this as a bug fix
    to make sure customers don't stuck on a version with old logic
    available.
    louis-launchdarkly authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    58d73ee View commit details
    Browse the repository at this point in the history
  2. merge from public after release

    LaunchDarklyReleaseBot committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    099e64c View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. fix: synchronize ConnectivityManager.updateDataSource to prevent race…

    …… (#311)
    
    … condition
    
    **Requirements**
    
    - [ ] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [ ] I have validated my changes against all supported platform
    versions
    
    **Related issues**
    
    
    https://app.shortcut.com/launchdarkly/story/229919/support-58536-crash-initializing-android-sdk
    
    **Describe the solution you've provided**
    
    Root cause of crash is that multiple calls to update from different
    sources can cause a event source to be stopped just before start is
    called on the event source. This results in the event source being in a
    bad state, leading to the crash. The fix is to only allow one thread
    into the updateDataSource block at a time by making it synchronized.
    
    **Describe alternatives you've considered**
    
    Also considered updating the event source to silently ignore the request
    to start again after it has been stopped. I prefer code less
    permissive/lenient code in this case since we really should know exactly
    when we are starting and stopping eventsources.
    tanderson-ld authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    942e0f5 View commit details
    Browse the repository at this point in the history