-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare 5.0.3 release #232
Commits on Jun 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1aa5822 - Browse repository at this point
Copy the full SHA 1aa5822View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb7d510 - Browse repository at this point
Copy the full SHA eb7d510View commit details -
[sc-205159] Update README with current number of flags served (#297)
Story details: https://app.shortcut.com/launchdarkly/story/205159
Configuration menu - View commit details
-
Copy full SHA for 6692363 - Browse repository at this point
Copy the full SHA 6692363View commit details
Commits on Jun 14, 2023
-
Contexts autopopulated with application and device information withou…
…t collision handling nor testing.
Configuration menu - View commit details
-
Copy full SHA for 07d822a - Browse repository at this point
Copy the full SHA 07d822aView commit details
Commits on Jun 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1441a1f - Browse repository at this point
Copy the full SHA 1441a1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b62f48e - Browse repository at this point
Copy the full SHA b62f48eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc44ac1 - Browse repository at this point
Copy the full SHA cc44ac1View commit details
Commits on Jun 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7fa4f9d - Browse repository at this point
Copy the full SHA 7fa4f9dView commit details
Commits on Jun 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0136dda - Browse repository at this point
Copy the full SHA 0136ddaView commit details -
feat: core implementation of auto environment attributes (#298)
**Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions. **Related issues** [Provide links to any issues in this repository or elsewhere relating to this pull request. ](https://app.shortcut.com/launchdarkly/story/204369/core-telemetry-in-android-sdk) **Describe the solution you've provided** See https://github.com/launchdarkly/sdk-specs/blob/ta/sc-203619/auto-env-attributes-software-specs/specs/CONTEXTENVDATA-context-environment-data/ImplementationGuidance.md#object-oriented-sdks-with-persistence **Describe alternatives you've considered** See https://launchdarkly.atlassian.net/wiki/spaces/PD/pages/2426306660/Mobile+Telemetry+Brainstorming+Investigation#Implementation-Ideas
Configuration menu - View commit details
-
Copy full SHA for f358aeb - Browse repository at this point
Copy the full SHA f358aebView commit details -
Configuration menu - View commit details
-
Copy full SHA for af85026 - Browse repository at this point
Copy the full SHA af85026View commit details -
This pull request was auto generated by the Launchdarkly Github Standards automation platform. * Add default CODEOWNERS file
Configuration menu - View commit details
-
Copy full SHA for a277bc6 - Browse repository at this point
Copy the full SHA a277bc6View commit details
Commits on Jul 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dad79ce - Browse repository at this point
Copy the full SHA dad79ceView commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3874ef3 - Browse repository at this point
Copy the full SHA 3874ef3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e59f81 - Browse repository at this point
Copy the full SHA 1e59f81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5026a89 - Browse repository at this point
Copy the full SHA 5026a89View commit details -
Ta/sc 204374/auto env opt in (#300)
**Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/204374/android-telemetry-add-opt-in-out-support **Describe the solution you've provided** Piped boolean through config and contract testing layers into LDClient's use of context modifiers. **Describe alternatives you've considered** None others strongly considered, current solution is pretty much the minimal solution.
Configuration menu - View commit details
-
Copy full SHA for 4646768 - Browse repository at this point
Copy the full SHA 4646768View commit details
Commits on Jul 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 80cd412 - Browse repository at this point
Copy the full SHA 80cd412View commit details
Commits on Jul 27, 2023
-
Added name to the OS object in ld_device recipe. (#301)
**Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions. **Related issues** https://app.shortcut.com/launchdarkly/story/208999/android-telemetry-implement-new-os-attribute-spec **Describe the solution you've provided** OS Name will take the form of "Android<SDKINT>". Example: Android21 **Describe alternatives you've considered** Android API 23 (too wordy) Android M (multiple ways to get the Letter code for the OS across different API levels, not worth the difficulty to implement. Also, they're going to run out of Letters, so seems risky over the next 5 years).
Configuration menu - View commit details
-
Copy full SHA for dff5018 - Browse repository at this point
Copy the full SHA dff5018View commit details -
Adding deterministic ld_application key generation to recipe and also…
… moved locale from ld_device to ld_application
Configuration menu - View commit details
-
Copy full SHA for add8304 - Browse repository at this point
Copy the full SHA add8304View commit details
Commits on Jul 28, 2023
-
Adding deterministic ld_application key generation to recipe and also…
…… (#302) … moved locale from ld_device to ld_application **Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/208863/android-telemetry-stable-ld-application-key **Describe the solution you've provided** Updated callable of the ld_application recipe. **Describe alternatives you've considered** Could have done a large closure for creating each context instead of having recipes, but there would be duplicated code related to iterating over the attributes and handling set failures. That seemed like a big enough con to dissuade me from doing that.
Configuration menu - View commit details
-
Copy full SHA for b1d8c79 - Browse repository at this point
Copy the full SHA b1d8c79View commit details
Commits on Jul 31, 2023
-
Added autoEnvAttributes required parameter to LDConfig. Adjusted rela…
…ted code and tests.
Configuration menu - View commit details
-
Copy full SHA for 1198f9f - Browse repository at this point
Copy the full SHA 1198f9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff596c2 - Browse repository at this point
Copy the full SHA ff596c2View commit details
Commits on Aug 1, 2023
-
Added autoEnvAttributes required parameter to LDConfig. Adjusted rel……
… (#303) **Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/204374/android-telemetry-add-opt-in-out-support **Describe the solution you've provided** In the next major version, customers must make a decision on whether to opt in/out of env attributes. A required parameter on the LDConfig constructor was chosen during the SDK technical discussion. The required parameter is an enum type for extra API clarity. **Describe alternatives you've considered** Other ideas considered during the SDK technical discussion a fluent builder with multiple types to control when the build() function can be called. alternative SDKs for the feature (possible, but high maintenance costs)
Configuration menu - View commit details
-
Copy full SHA for 5ce1735 - Browse repository at this point
Copy the full SHA 5ce1735View commit details
Commits on Aug 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ede22d8 - Browse repository at this point
Copy the full SHA ede22d8View commit details -
Feature/auto attributes (#305)
Merging feature branch into 5.x branch.
Configuration menu - View commit details
-
Copy full SHA for d2478c7 - Browse repository at this point
Copy the full SHA d2478c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9378f6 - Browse repository at this point
Copy the full SHA e9378f6View commit details -
Deprecating LDUser and related functionality. (#304)
**Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/210352/android-add-deprecation-warnings-for-lduser-functionality
Configuration menu - View commit details
-
Copy full SHA for 74bb9cb - Browse repository at this point
Copy the full SHA 74bb9cbView commit details -
merge from public after release
LaunchDarklyReleaseBot committedAug 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 0c78ca7 - Browse repository at this point
Copy the full SHA 0c78ca7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4c4661 - Browse repository at this point
Copy the full SHA f4c4661View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4742f96 - Browse repository at this point
Copy the full SHA 4742f96View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcca763 - Browse repository at this point
Copy the full SHA dcca763View commit details -
Removing previously deprecated LDUser and related functionality. (#306)
**Requirements** - [ ] I have added test coverage for new or changed functionality Only removing code, so not additional coverage. - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/210354/android-remove-lduser-in-the-auto-env-branch **Describe the solution you've provided** Pew, pew, pewwww, pew pew. Die LDUser, die!
Configuration menu - View commit details
-
Copy full SHA for 9f46680 - Browse repository at this point
Copy the full SHA 9f46680View commit details -
Updating env attributes spec version to 1.0 for production release. (…
…#307) Documentation pass found one version that needed to be updated.
Configuration menu - View commit details
-
Copy full SHA for b162aa3 - Browse repository at this point
Copy the full SHA b162aa3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 081d283 - Browse repository at this point
Copy the full SHA 081d283View commit details -
merge from public after release
LaunchDarklyReleaseBot committedAug 3, 2023 Configuration menu - View commit details
-
Copy full SHA for a76ed9b - Browse repository at this point
Copy the full SHA a76ed9bView commit details
Commits on Aug 24, 2023
-
fix: updating sanitization, validation, and fallback logic of Auto En…
…v Attributes to be more consistent and user friendly.
Configuration menu - View commit details
-
Copy full SHA for 9b1d1ad - Browse repository at this point
Copy the full SHA 9b1d1adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3071d45 - Browse repository at this point
Copy the full SHA 3071d45View commit details -
Update launchdarkly-android-client-sdk/src/test/java/com/launchdarkly…
…/sdk/android/LDUtilTest.java Co-authored-by: Matthew M. Keeler <keelerm84@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5f2bbf9 - Browse repository at this point
Copy the full SHA 5f2bbf9View commit details
Commits on Aug 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 68b1b70 - Browse repository at this point
Copy the full SHA 68b1b70View commit details -
fix: updating sanitization, validation, and fallback logic of Auto En…
…… (#309) Need to merge test harness changes before this will pass. **Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/213112/inconsistent-applicationname-and-applicationversionname-validation **Describe the solution you've provided** - Added sanitization logic to application info fields where spaces are now converted to hyphens. This is to help customers create values that will be accepted by our cloud infrasturcture. - Updated fallback logic to fallback to next source of application info if the applicationID is invalid. This invalid ID would be rejected by the cloud, so making that consistent. - Fixing bug in hashing to calulcate ld_application key where an omitted version would actually result in hash("myID:nil") when it should have been hash("myID:") **Describe alternatives you've considered** See: https://launchdarkly.atlassian.net/wiki/spaces/~63fb3c420d9b61193c23bde7/pages/2544828779/213112+-+Consistent+application+info+validation
Configuration menu - View commit details
-
Copy full SHA for 9e2c786 - Browse repository at this point
Copy the full SHA 9e2c786View commit details -
merge from public after release
LaunchDarklyReleaseBot committedAug 25, 2023 Configuration menu - View commit details
-
Copy full SHA for 54474f5 - Browse repository at this point
Copy the full SHA 54474f5View commit details
Commits on Sep 19, 2023
-
fix: Change the ld_application id generation logic (#310)
We have discussed and agreed to modify the logic to not include the version as the context key generation. We will release this as a bug fix to make sure customers don't stuck on a version with old logic available.
Configuration menu - View commit details
-
Copy full SHA for 58d73ee - Browse repository at this point
Copy the full SHA 58d73eeView commit details -
merge from public after release
LaunchDarklyReleaseBot committedSep 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 099e64c - Browse repository at this point
Copy the full SHA 099e64cView commit details
Commits on Feb 1, 2024
-
fix: synchronize ConnectivityManager.updateDataSource to prevent race…
…… (#311) … condition **Requirements** - [ ] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [ ] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/229919/support-58536-crash-initializing-android-sdk **Describe the solution you've provided** Root cause of crash is that multiple calls to update from different sources can cause a event source to be stopped just before start is called on the event source. This results in the event source being in a bad state, leading to the crash. The fix is to only allow one thread into the updateDataSource block at a time by making it synchronized. **Describe alternatives you've considered** Also considered updating the event source to silently ignore the request to start again after it has been stopped. I prefer code less permissive/lenient code in this case since we really should know exactly when we are starting and stopping eventsources.
Configuration menu - View commit details
-
Copy full SHA for 942e0f5 - Browse repository at this point
Copy the full SHA 942e0f5View commit details