Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FLAG_UPDATE_CURRENT to create PendingIntent #87

Closed
wants to merge 1 commit into from

Conversation

sambroad
Copy link

Potential fix for: #83
based on https://stackoverflow.com/a/29703161

@gwhelanLD gwhelanLD self-assigned this Oct 18, 2019
@gwhelanLD
Copy link
Contributor

Hi @sambroad,

Thanks for this PR. This is definitely an approach we are looking at for fixing #83, but we need to do a bit more investigation to validate that this is the approach we want to take on this issue.

We have not prioritized this work yet as initial triaging has indicated the conditions for triggering this issue should limit the impact substantially. That said, we hope to take on this work soon.

Thanks,
@gwhelanLD

@sambroad
Copy link
Author

Thanks for your answer. I appreciate you looking into this, and understand you need to be cautious not to introduce any side effects.
This fix solved the same issue when we applied it in our codebase.
#83 is now the most reported crash in our app, so I look forward to seeing it prioritized soon.

@gwhelanLD
Copy link
Contributor

We've just released version 2.9.1 of the Android SDK, which should address #83, although in a different manner than proposed in this PR. Please see the discussion on the issue for more information on our investigation and our ultimate solution.

I'm going to close this PR as the issue it was intended to address has now been closed. Thanks again for suggesting this change, even though we ultimately went with a different approach.

@gwhelanLD gwhelanLD closed this Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants