feat: Adds support for client-side prerequisite events #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
commented
Oct 30, 2024
| @@ -50,7 +50,7 @@ final class DefaultEventProcessor implements EventProcessor { | |||
|
|
|||
| DefaultEventProcessor( | |||
| {required LDLogger logger, | |||
| bool indexEvents = false, | |||
| required bool indexEvents, | |||
There was a problem hiding this comment.
For reviewers: I was trying to find a way to not have to tweak this, but the typedef of EventProcessorFactory was not handling the optional named parameter with default well.
There was a problem hiding this comment.
I am not sure I see why the type here needs to change, it seems like it would just get redundantly passed, which should be fine. Like required at the factory level, but not at the constructor level.
That said I am indifferent to the change.
tanderson-ld
commented
Oct 30, 2024
| required bool allAttributesPrivate, | ||
| required Set<AttributeReference> globalPrivateAttributes, | ||
| DiagnosticsManager? diagnosticsManager} | ||
| ); |
There was a problem hiding this comment.
For reviewers: Added for test injection.
kinyoklion
reviewed
Oct 30, 2024
kinyoklion
approved these changes
Oct 30, 2024
This was referenced Oct 31, 2024
tanderson-ld
pushed a commit
that referenced
this pull request
Oct 31, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](launchdarkly_dart_common-v1.2.1...launchdarkly_dart_common-v1.3.0) (2024-10-31) ### Features * Adds support for client-side prerequisite events ([#172](#172)) ([7a042c2](7a042c2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
tanderson-ld
added a commit
that referenced
this pull request
Oct 31, 2024
🤖 I have created a release *beep* *boop* --- ## [1.4.0](launchdarkly_common_client-v1.3.1...launchdarkly_common_client-v1.4.0) (2024-10-31) ### Features * Adds support for client-side prerequisite events ([#172](#172)) ([7a042c2](7a042c2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Todd Anderson <127344469+tanderson-ld@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
I have added test coverage for new or changed functionality
I have followed the repository's pull request submission guidelines
I have validated my changes against all supported platform versions
Exception: Changes are not related to platforms.
Related issues
SDK-691