Skip to content

refactor: add internal data system config #171

refactor: add internal data system config

refactor: add internal data system config #171

Triggered via pull request September 24, 2024 21:21
Status Failure
Total duration 46s
Artifacts

ldotel-ci.yml

on: pull_request
go-versions  /  go-versions
5s
go-versions / go-versions
Matrix: test-linux
Fit to window
Zoom out
Zoom in

Annotations

30 errors
ldotel Linux, Go 1.22: internal/datasourcev2/polling_data_source.go#L212
Error return value of `pp.dataDestination.SetBasis` is not checked (errcheck)
ldotel Linux, Go 1.22: internal/datasourcev2/polling_data_source.go#L214
Error return value of `pp.dataDestination.ApplyDelta` is not checked (errcheck)
ldotel Linux, Go 1.22: internal/datasourcev2/streaming_data_source.go#L280
Error return value of `sp.dataDestination.SetBasis` is not checked (errcheck)
ldotel Linux, Go 1.22: internal/datasourcev2/streaming_data_source.go#L284
Error return value of `sp.dataDestination.ApplyDelta` is not checked (errcheck)
ldotel Linux, Go 1.22: internal/datasystem/fdv2_datasystem.go#L312
commentFormatting: put a space between `//` and comment text (gocritic)
ldotel Linux, Go 1.22: testhelpers/ldservicesv2/server_sdk_data.go#L69
Consider pre-allocating `objs` (prealloc)
ldotel Linux, Go 1.22: internal/datastatus/data_status.go#L3
exported: exported type DataStatus should have comment or be unexported (revive)
ldotel Linux, Go 1.22: internal/fdv2proto/event_to_storable_item.go#L8
exported: exported function ToStorableItems should have comment or be unexported (revive)
ldotel Linux, Go 1.22: internal/fdv2proto/events.go#L9
exported: exported type IntentCode should have comment or be unexported (revive)
ldotel Linux, Go 1.22: internal/fdv2proto/events.go#L12
exported: exported const IntentTransferFull should have comment (or a comment on this block) or be unexported (revive)
ldotel Linux, Go 1.23: internal/datasourcev2/polling_data_source.go#L212
Error return value of `pp.dataDestination.SetBasis` is not checked (errcheck)
ldotel Linux, Go 1.23: internal/datasourcev2/polling_data_source.go#L214
Error return value of `pp.dataDestination.ApplyDelta` is not checked (errcheck)
ldotel Linux, Go 1.23: internal/datasourcev2/streaming_data_source.go#L280
Error return value of `sp.dataDestination.SetBasis` is not checked (errcheck)
ldotel Linux, Go 1.23: internal/datasourcev2/streaming_data_source.go#L284
Error return value of `sp.dataDestination.ApplyDelta` is not checked (errcheck)
ldotel Linux, Go 1.23: internal/datasystem/fdv2_datasystem.go#L312
commentFormatting: put a space between `//` and comment text (gocritic)
ldotel Linux, Go 1.23: testhelpers/ldservicesv2/server_sdk_data.go#L69
Consider pre-allocating `objs` (prealloc)
ldotel Linux, Go 1.23: internal/datastatus/data_status.go#L3
exported: exported type DataStatus should have comment or be unexported (revive)
ldotel Linux, Go 1.23: internal/fdv2proto/selector.go#L3
exported: exported type Selector should have comment or be unexported (revive)
ldotel Linux, Go 1.23: internal/fdv2proto/selector.go#L9
exported: exported function NoSelector should have comment or be unexported (revive)
ldotel Linux, Go 1.23: internal/fdv2proto/selector.go#L13
exported: exported function NewSelector should have comment or be unexported (revive)
ldotel Linux, Go 1.18: internal/datasourcev2/polling_data_source.go#L212
Error return value of `pp.dataDestination.SetBasis` is not checked (errcheck)
ldotel Linux, Go 1.18: internal/datasourcev2/polling_data_source.go#L214
Error return value of `pp.dataDestination.ApplyDelta` is not checked (errcheck)
ldotel Linux, Go 1.18: internal/datasourcev2/streaming_data_source.go#L280
Error return value of `sp.dataDestination.SetBasis` is not checked (errcheck)
ldotel Linux, Go 1.18: internal/datasourcev2/streaming_data_source.go#L284
Error return value of `sp.dataDestination.ApplyDelta` is not checked (errcheck)
ldotel Linux, Go 1.18: internal/datasystem/fdv2_datasystem.go#L312
commentFormatting: put a space between `//` and comment text (gocritic)
ldotel Linux, Go 1.18: testhelpers/ldservicesv2/server_sdk_data.go#L69
Consider pre-allocating `objs` (prealloc)
ldotel Linux, Go 1.18: internal/datastatus/data_status.go#L3
exported: exported type DataStatus should have comment or be unexported (revive)
ldotel Linux, Go 1.18: internal/fdv2proto/selector.go#L3
exported: exported type Selector should have comment or be unexported (revive)
ldotel Linux, Go 1.18: internal/fdv2proto/selector.go#L9
exported: exported function NoSelector should have comment or be unexported (revive)
ldotel Linux, Go 1.18: internal/fdv2proto/selector.go#L13
exported: exported function NewSelector should have comment or be unexported (revive)