refactor: streaming/polling processors take DataDestination/StatusReporter interfaces #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sdk-556/refactor-processor-interfaces
branch
from
df8afaf
to
be89344
Compare
cwaldren-ld
changed the title
cwaldren-ld
force-pushed
the
cw/sdk-556/refactor-processor-interfaces
branch
from
6c5fadb
to
7b0cf44
Compare
keelerm84
approved these changes
Sep 18, 2024
Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com>
Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change splits up the monolithic
DataSourceUpdateSinkinto two:DataDestination: where data goesStatusReporter: where statuses goThis makes it easier to mock them for testing, and also represents a cleaner separation of concerns. Finally, these interfaces are slightly different than the
DataSourceUpdateSinkfor FDV1 vs FDV2.In the new system, we want to be able to do things like passing a payload version in
Init.I've added doc comments that these interfaces are not stable, since they are public.