Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce memorystorev2 #193

Merged
merged 7 commits into from
Sep 24, 2024
Merged

chore: introduce memorystorev2 #193

merged 7 commits into from
Sep 24, 2024

Conversation

cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented Sep 24, 2024

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Describe the solution you've provided

This adds a memorystorev2 package containing an alternative Memory Store implementation designed specifically for FDv2 usage.

It is similar to the existing memory store, with obsolete methods removed and new methods added - but the core upsert/init logic remains the same.

I've converted the existing unit tests and benchmarks to the new store.

Describe alternatives you've considered

Augment the existing memory store with FDv2 functionality. I did this at first, and although it worked, it wasn't clean. It meant the store needed to retain obsolete functions, and it wasn't clear how the FDv2 methods interacted with FDv1 methods. Example: SetBasis vs Init, seems redundant.

Additional context

This component is necessary for the dual-mode persistent/memory store PR.

@cwaldren-ld cwaldren-ld marked this pull request as ready for review September 24, 2024 01:24
@cwaldren-ld cwaldren-ld requested a review from a team as a code owner September 24, 2024 01:24
internal/memorystorev2/memory_store.go Outdated Show resolved Hide resolved
@cwaldren-ld cwaldren-ld merged commit ec154cd into v7 Sep 24, 2024
18 of 19 checks passed
@cwaldren-ld cwaldren-ld deleted the cw/sdk-709/memory-store branch September 24, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants