Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Describe the solution you've provided
This adds a
memorystorev2
package containing an alternative Memory Store implementation designed specifically for FDv2 usage.It is similar to the existing memory store, with obsolete methods removed and new methods added - but the core
upsert/init
logic remains the same.I've converted the existing unit tests and benchmarks to the new store.
Describe alternatives you've considered
Augment the existing memory store with FDv2 functionality. I did this at first, and although it worked, it wasn't clean. It meant the store needed to retain obsolete functions, and it wasn't clear how the FDv2 methods interacted with FDv1 methods. Example:
SetBasis
vsInit
, seems redundant.Additional context
This component is necessary for the dual-mode persistent/memory store PR.