Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependency bounds #25

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Bump dependency bounds #25

merged 1 commit into from
Feb 22, 2021

Conversation

dbaynard
Copy link
Contributor

@dbaynard dbaynard commented Feb 18, 2021 •
edited
Loading

The package builds with the new dependencies, and the test suite passes.

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

n/a

Describe the solution you've provided

I've bumped the upper bounds on non-boot dependencies. While I expect no change with the new versions of bytestring and text I haven't been able to test with those updates.

Describe alternatives you've considered

n/a

Additional context

I tested the new dependency versions using the following stack.yaml file

resolver: lts-17.2

packages:
- .

extra-deps:
- base16-bytestring-1.0.1.0@sha256:33b9d57afa334d06485033e930c6b13fc760baf88fd8f715ae2f9a4b46e19a54
- generic-lens-2.1.0.0@sha256:1af786fb2f347077266f4a137373c718cada59e2a2ed0aa0f5395d805ef9a18d
- generic-lens-core-2.1.0.0@sha256:8d650800aa4779366bd5639dce95662a5e368a044f4587689129bce44f2c5be6

Thanks!

@dbaynard
Bump non-boot dependency bounds
0acdb4c 
The package builds and test suite passes with the current stack.yaml.

With the new version of base16-bytestring, however, the test suites in
the cryptohash-* dependencies need updates.
@hroederld
Copy link
Contributor

Awesome thanks! Pardon the delay I should of looked at this sooner.

@hroederld hroederld merged commit 51f564c into launchdarkly:master Feb 22, 2021
@dbaynard
Copy link
Contributor Author

Thanks. Would you please cut a new hackage revision, (or release) with these changes?

@dbaynard dbaynard mentioned this pull request Mar 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbaynard @hroederld