Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check in Cabal file; basic GitHub actions #37

Closed
wants to merge 3 commits into from
Closed

check in Cabal file; basic GitHub actions #37

wants to merge 3 commits into from

Conversation

peterbecich
Copy link

@peterbecich peterbecich commented Feb 19, 2022

This allows the project to be built with Cabal. In its current state I think haskell-server-sdk cannot be used as a pinned dependency in a cabal.project; this error is given: NoCabalFileFound

Basic GitHub Actions for the Cabal file are provided. Everything works for GHC 8.6, 8.8, and 8.10, but GHC 9.0 fails: https://github.com/peterbecich/haskell-server-sdk/runs/5255432273?check_suite_focus=true

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Describe the solution you've provided

Check in haskell-server-sdk.cabal generated by Stack from package.yaml.

Describe alternatives you've considered

Additional context

@peterbecich peterbecich marked this pull request as ready for review February 19, 2022 01:12
@louis-launchdarkly
Copy link
Contributor

Hello @peterbecich, thank you for your contribution. There are two changes in your PR, and while we are still discussing the Cabal portion of the change, we have decided that we are not going to take the Github Action portion of the change.

LaunchDarkly builds the Haskell SDK through CircleCI, and while this is not visible on the public mirror, there is already a change to test build across different GHC versions. We will keep the build in CircleCI, and make sure we address the 9.0 version correctly.

@peterbecich
Copy link
Author

Great, thank you @louis-launchdarkly

@fumieval
Copy link

fumieval commented May 9, 2022

FYI, lack of .cabal file implies that users of cabal-install are unable to use the package via GitHub (using source-repository-package). This is problematic when one wants to use an unreleased version of haskell-server-sdk.

@keelerm84
Copy link
Member

The cabal file is now being committed as of 3.0.3. Sorry it took so long to reach a resolution on this, but I hope this helps going forward.

@keelerm84 keelerm84 closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants